fix: separate model and deployment for OpenAIEmbeddings #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated document_model_name and query_model_name
tunayokumus
changed the title
dev2049
reviewed
Apr 18, 2023
| # TODO: deprecate these two in favor of model | ||
| # https://community.openai.com/t/api-update-engines-models/18597 | ||
| # https://github.com/openai/openai-python/issues/132 | ||
| document_model_name: str = "text-embedding-ada-002" |
There was a problem hiding this comment.
@hwchase17 technically breaking change, how do we feel about it
|
Thanks for the update! This still results in I am assuming there is nothing we can do about that and it is on Azures end ( besides |
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
…#3076) Separated the deployment from model to support Azure OpenAI Embeddings properly. Also removed the deprecated document_model_name and query_model_name attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated the deployment from model to support Azure OpenAI Embeddings properly.
Also removed the deprecated document_model_name and query_model_name attributes.