Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in method name for creating an issue on JIRA #3307

Merged
merged 3 commits into from Apr 21, 2023

Conversation

varun1505
Copy link
Contributor

The awesome JIRA tool created by @zywilliamli calls the create_issue() method to create issues, however, the actual method is issue_create().

Details in the Documentation here: https://atlassian-python-api.readthedocs.io/jira.html#manage-issues

@dev2049
Copy link
Contributor

dev2049 commented Apr 21, 2023

good catch! should we add an integration test to make sure?

@varun1505
Copy link
Contributor Author

@dev2049 Integration Tests would mean we'll have to manage JIRA API keys. Not sure how to do that. :/
Any thoughts?

@dev2049
Copy link
Contributor

dev2049 commented Apr 21, 2023

@dev2049 Integration Tests would mean we'll have to manage JIRA API keys. Not sure how to do that. :/
Any thoughts?

integration tests aren't actually run in CI or anything at the moment. they just make it easy to test things locally. so as long as you had jira keys in your env and ran the integration test it would work. see the other tests/integration_tests/utilities/... for examples

@varun1505
Copy link
Contributor Author

Thanks for the pointer @dev2049 . I've added the tests. Let me know if this is good to go!

@dev2049 dev2049 merged commit d2f922f into langchain-ai:master Apr 21, 2023
5 of 9 checks passed
@dev2049
Copy link
Contributor

dev2049 commented Apr 21, 2023

Thanks @varun1505!

vowelparrot pushed a commit that referenced this pull request Apr 21, 2023
The awesome JIRA tool created by @zywilliamli calls the `create_issue()`
method to create issues, however, the actual method is `issue_create()`.

Details in the Documentation here:
https://atlassian-python-api.readthedocs.io/jira.html#manage-issues
vowelparrot pushed a commit that referenced this pull request Apr 26, 2023
The awesome JIRA tool created by @zywilliamli calls the `create_issue()`
method to create issues, however, the actual method is `issue_create()`.

Details in the Documentation here:
https://atlassian-python-api.readthedocs.io/jira.html#manage-issues
vowelparrot pushed a commit that referenced this pull request Apr 28, 2023
The awesome JIRA tool created by @zywilliamli calls the `create_issue()`
method to create issues, however, the actual method is `issue_create()`.

Details in the Documentation here:
https://atlassian-python-api.readthedocs.io/jira.html#manage-issues
samching pushed a commit to samching/langchain that referenced this pull request May 1, 2023
The awesome JIRA tool created by @zywilliamli calls the `create_issue()`
method to create issues, however, the actual method is `issue_create()`.

Details in the Documentation here:
https://atlassian-python-api.readthedocs.io/jira.html#manage-issues
yanghua pushed a commit to yanghua/langchain that referenced this pull request May 9, 2023
The awesome JIRA tool created by @zywilliamli calls the `create_issue()`
method to create issues, however, the actual method is `issue_create()`.

Details in the Documentation here:
https://atlassian-python-api.readthedocs.io/jira.html#manage-issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants