[Fix #3365]: Changed regex to cover new line before action serious #3367
Conversation
Changed regex to cover new line before action serious. regex101: https://regex101.com/r/CXl1kB/1
My-
force-pushed
the
fix-3365_newline_before_action
branch
from
e9dc8f1
to
f55905b
Compare
@hwchase17 no, it is Thank you for this project :) PS: I run Linter and I hope the build will pass now :) |
|
Since this PR got merged I am getting ValueError: Could not parse LLM output: |
…3367) Fix for: [Changed regex to cover new line before action serious.](#3365) --- This PR fixes the issue where `ValueError: Could not parse LLM output:` was thrown on seems to be valid input. Changed regex to cover new lines before action serious (after the keywords "Action:" and "Action Input:"). regex101: https://regex101.com/r/CXl1kB/1 --------- Co-authored-by: msarskus <msarskus@cisco.com>
…3367) Fix for: [Changed regex to cover new line before action serious.](#3365) --- This PR fixes the issue where `ValueError: Could not parse LLM output:` was thrown on seems to be valid input. Changed regex to cover new lines before action serious (after the keywords "Action:" and "Action Input:"). regex101: https://regex101.com/r/CXl1kB/1 --------- Co-authored-by: msarskus <msarskus@cisco.com>
…n serious (langchain-ai#3367) Fix for: [Changed regex to cover new line before action serious.](langchain-ai#3365) --- This PR fixes the issue where `ValueError: Could not parse LLM output:` was thrown on seems to be valid input. Changed regex to cover new lines before action serious (after the keywords "Action:" and "Action Input:"). regex101: https://regex101.com/r/CXl1kB/1 --------- Co-authored-by: msarskus <msarskus@cisco.com>
@ananyatripathi is that all output you are getting? I mean there are no keywords like "Action", "Action Input" or others? My change should allow having a new line after the keyword which was giving an error before... and to my understanding not having keywords is a ValueError... maybe your string/prompt is final and just missing the "Final Answer" keyword... Probably you could create an issue and we could continue the discussion there. I might lack experience but I hope I will be able to find how my change could add to the braking change. |
…n serious (langchain-ai#3367) Fix for: [Changed regex to cover new line before action serious.](langchain-ai#3365) --- This PR fixes the issue where `ValueError: Could not parse LLM output:` was thrown on seems to be valid input. Changed regex to cover new lines before action serious (after the keywords "Action:" and "Action Input:"). regex101: https://regex101.com/r/CXl1kB/1 --------- Co-authored-by: msarskus <msarskus@cisco.com>
Fix for: Changed regex to cover new line before action serious.
This PR fixes the issue where
ValueError: Could not parse LLM output:was thrown on seems to be valid input.Changed regex to cover new lines before action serious (after the keywords "Action:" and "Action Input:").
regex101: https://regex101.com/r/CXl1kB/1