adding add_documents and aadd_documents to class RedisVectorStoreRetriever #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iever in vectorstores/redis.py to create an interface to add_texts for agents to use
vowelparrot
approved these changes
Apr 25, 2023
vowelparrot
pushed a commit
that referenced
this pull request
Apr 26, 2023
…iever (#3419) Ran into this issue In vectorstores/redis.py when trying to use the AutoGPT agent with redis vector store. The error I received was ` langchain/experimental/autonomous_agents/autogpt/agent.py", line 134, in run self.memory.add_documents([Document(page_content=memory_to_add)]) AttributeError: 'RedisVectorStoreRetriever' object has no attribute 'add_documents' ` Added the needed function to the class RedisVectorStoreRetriever which did not have the functionality like the base VectorStoreRetriever in vectorstores/base.py that, for example, vectorstores/faiss.py has
vowelparrot
pushed a commit
that referenced
this pull request
Apr 28, 2023
…iever (#3419) Ran into this issue In vectorstores/redis.py when trying to use the AutoGPT agent with redis vector store. The error I received was ` langchain/experimental/autonomous_agents/autogpt/agent.py", line 134, in run self.memory.add_documents([Document(page_content=memory_to_add)]) AttributeError: 'RedisVectorStoreRetriever' object has no attribute 'add_documents' ` Added the needed function to the class RedisVectorStoreRetriever which did not have the functionality like the base VectorStoreRetriever in vectorstores/base.py that, for example, vectorstores/faiss.py has
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
…iever (langchain-ai#3419) Ran into this issue In vectorstores/redis.py when trying to use the AutoGPT agent with redis vector store. The error I received was ` langchain/experimental/autonomous_agents/autogpt/agent.py", line 134, in run self.memory.add_documents([Document(page_content=memory_to_add)]) AttributeError: 'RedisVectorStoreRetriever' object has no attribute 'add_documents' ` Added the needed function to the class RedisVectorStoreRetriever which did not have the functionality like the base VectorStoreRetriever in vectorstores/base.py that, for example, vectorstores/faiss.py has
yanghua
pushed a commit
to yanghua/langchain
that referenced
this pull request
May 9, 2023
…iever (langchain-ai#3419) Ran into this issue In vectorstores/redis.py when trying to use the AutoGPT agent with redis vector store. The error I received was ` langchain/experimental/autonomous_agents/autogpt/agent.py", line 134, in run self.memory.add_documents([Document(page_content=memory_to_add)]) AttributeError: 'RedisVectorStoreRetriever' object has no attribute 'add_documents' ` Added the needed function to the class RedisVectorStoreRetriever which did not have the functionality like the base VectorStoreRetriever in vectorstores/base.py that, for example, vectorstores/faiss.py has
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this issue In vectorstores/redis.py when trying to use the AutoGPT agent with redis vector store. The error I received was
langchain/experimental/autonomous_agents/autogpt/agent.py", line 134, in run self.memory.add_documents([Document(page_content=memory_to_add)]) AttributeError: 'RedisVectorStoreRetriever' object has no attribute 'add_documents'Added the needed function to the class RedisVectorStoreRetriever which did not have the functionality like the base VectorStoreRetriever in vectorstores/base.py that, for example, vectorstores/faiss.py has