Pandas agent: Pass callback manager to Python tool. #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback manager was not passed to the Python tool, making it hard to observe some intermediate steps.
|
Thank you for the PR! We are doing a big overhaul of callbacks and will address this, though that may cause aslight delay in landing this pR in particular |
|
That sounds good. The callbacks system as it is right now does seem a bit fragile; excited to see what you manage to do :) I guess you're talking about e.g. this: #3256 ? (just curious) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback manager was not passed to the Python tool, making it hard to observe some intermediate steps.
NOTE: The mypy hints seem to suggest that the tool does not accept None as an input—but I didn't check the code—so I use get_callback_manager() to get the real default callback manager in case None is passed to the Pandas tool.