Fix compatiblity with SQLAlchemy 1.3 #3958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchase17
reviewed
May 4, 2023
|
Or maybe make SQLAlchemy an optional dependency? 99% of langchain can be used without it and we are currently at a point where we can't update langchain because we use sqlalchemy 1.3 |
|
+1 for supporting 1.3, the 1.3 => 1.4 migration isn't easy |
|
@hrist0stoichev hows this? this changes it so there won't be any errors on import. we could look into making truly optional, but would take a bit more effort |
|
(if you want to make truly optional, id accept that pr instead) |
|
yeah, #4647 looks good enough |
dosubot
bot
added
Ɑ: memory
|
sounds like this has been resolved, let me know if i'm missing something! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this issue and this PR.
It seems there are more thing that depends on
sqlalchemy >= 1.4so I'm fixing those in this PR. Also, locking SQLAlchemy to1.3.24so that the build step will fail if something that depends onsqlalchemy >= 1.4is added.from sqlalchemy.orm import declarative_base->from sqlalchemy.ext.declarative import declarative_basewith Session()->session = Session(); try: ... finally: session.close()query().where()->query().filter()-whereis synonym forfilterin 1.4select()->query()- TheselectAPI is quite different in 1.3.exec_driver_sql()->execute()- this is a synonym in 1.4I realize this change is becoming quite complex so another approach might be to just revert my previous PR and start depending on
sqlalchemy >= 1.4again but I still think that backwards compatibility is more important for a library so I will just submit this PR for review.