Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update V2 Tracer #4193

Merged
merged 1 commit into from May 5, 2023
Merged

Update V2 Tracer #4193

merged 1 commit into from May 5, 2023

Conversation

vowelparrot
Copy link
Contributor

@vowelparrot vowelparrot commented May 5, 2023 •
edited

  • Update the RunCreate object to work with recent changes
  • Add optional Example ID to the tracer
  • Adjust default persist_session behavior to attempt to load the session if it exists
  • Raise more useful HTTP errors for logging
  • Add unit testing
  • Fix the default ID to be a UUID for v2 tracer sessions

Broken out from the big draft here: #4061

@vowelparrot vowelparrot requested a review from agola11 May 5, 2023 21:12
@vowelparrot
Update V2 Tracer
15afdd0 
- Update the RunCreate object to work with recent changes
- Adjust default persist_session behavior to attempt to
load the session if it exists
- Raise more useful HTTP errors for logging
- Add unit testing
@vowelparrot vowelparrot merged commit a30f42d into master May 5, 2023
9 checks passed
@vowelparrot vowelparrot deleted the vwp/lcp_client branch May 5, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agola11 agola11 agola11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vowelparrot @agola11