Bug/4299 cant instantiate simplechatmodel subclass without defining agenerate #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vowelparrot
reviewed
May 7, 2023
| @@ -197,6 +197,14 @@ def _generate( | |||
| generation = ChatGeneration(message=message) | |||
| return ChatResult(generations=[generation]) | |||
|
|
|||
| def _agenerate( | |||
There was a problem hiding this comment.
Thanks for the PR!
This will have to be an async method. Will defer to @agola11 on whether it makes sense to have it default to
await asyncio.get_event_loop().run_in_executor(self._generate(messages, stop=stop, run_manager=run_manager)
There was a problem hiding this comment.
Yeah, this needs to be async and we should not be calling blocking code in async methods. A good solution is having the default implementation for async def _agenerate call run_in_executor, as @vowelparrot suggested
There was a problem hiding this comment.
how does this look
…chatmodel-subclass-without-defining-agenerate
…chatmodel-subclass-without-defining-agenerate
…chatmodel-subclass-without-defining-agenerate
|
Coming back to this tomorrow |
dosubot
bot
added
the
🤖:bug
|
believe this was resolved in #4701, let me know if i'm missing something! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4299