Ensure deployment_id is set to provided deployment, required for Azure OpenAI. #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we just revert #4915? seems like the api update they were referring to was specific to completion endpoints, so we shouldn't have changed in first place |
|
Also valid, I’m out for most of the evening so won’t be able to update this
PR till after 10pm (ideally could keep the test?)
Revert also works though so if fix can’t wait revert seems easiest.
Cheers,
Lucas
…On Fri, May 19, 2023 at 14:51 Davis Chase ***@***.***> wrote:
should we just revert #4915
<#4915>? seems like the api
update they were referring to was specific to completion endpoints, so we
shouldn't have changed in first place
—
Reply to this email directly, view it on GitHub
<#5002 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM5EOTTGUQXROMPIOEIATLXG7TPHANCNFSM6AAAAAAYIGYW4I>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
will revert for now and we can add tests in follow-up |
|
@dev2049 Updated this PR to only have unit test. |
hwchase17
reviewed
May 21, 2023
|
|
||
| try: | ||
| query_result = embeddings.embed_query(text) | ||
| except error.InvalidRequestError as e: |
There was a problem hiding this comment.
sorry what is this testing?
There was a problem hiding this comment.
That deployment_id/engine is set on openai.Embeddings when the api_type is azure. Basically a regression test against a similar change being made as the one that was reverted in response to this PR.
dosubot
bot
added
Ɑ: embeddings
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
baskaryan
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure deployment_id is set to provided deployment, required for Azure OpenAI.
Fixes #5001
Before submitting
Verified in my own code and by running this example notebook, works after the fix (as in it doesn't fail before trying to talk to the endpoint): https://github.com/hwchase17/langchain/blob/22d844dc0795e7e53a4cc499bf4974cb83df490d/docs/modules/models/text_embedding/examples/azureopenai.ipynb
Who can review?
@agola11 @hwchase17