Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harrison/spark reader #5405

Merged
merged 6 commits into from
May 30, 2023
Merged

Harrison/spark reader #5405

merged 6 commits into from
May 30, 2023

Conversation

hwchase17
Copy link
Contributor

No description provided.

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 29, 2023
@dev2049 dev2049 added 03 enhancement Enhancement of existing functionality Ɑ: doc loader Related to document loader module (not documentation) labels May 29, 2023
@dev2049 dev2049 merged commit 760632b into master May 30, 2023
13 checks passed
@dev2049 dev2049 deleted the harrison/spark-reader branch May 30, 2023 03:23
@TSPereira
Copy link

TSPereira commented May 30, 2023 •
edited

Just an heads up, this PR introduces a dependency for psutil which apparently doesn't exist by default in all python container images. I got some issues cause my ci suddenly started failing cause when running pytest it couldn't find psutil.

For context, running python 3.11

@dev2049
Copy link
Contributor

dev2049 commented May 30, 2023

Just an heads up, this PR introduces a dependency for psutil which apparently doesn't exist by default in all python container images. I got some issues cause my ci suddenly started failing cause when running pytest it couldn't find psutil.

For context, running python 3.11

great catch, thanks for heads up @TSPereira

vowelparrot pushed a commit that referenced this pull request May 31, 2023
@hwchase17 @rithwik-db
@dev2049 @vowelparrot
Harrison/spark reader (#5405)
7c4a0aa 
Co-authored-by: Rithwik Ediga Lakhamsani <rithwik.ediga@databricks.com>
Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
@hwchase17 @rithwik-db
@dev2049 @Undertone0809
Harrison/spark reader (langchain-ai#5405)
242de3c 
Co-authored-by: Rithwik Ediga Lakhamsani <rithwik.ediga@databricks.com>
Co-authored-by: Dev 2049 <dev.dev2049@gmail.com>
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 enhancement Enhancement of existing functionality Ɑ: doc loader Related to document loader module (not documentation) lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hwchase17 @TSPereira @dev2049 @rithwik-db