Use client from LCP-SDK #5695
Merged
Use client from LCP-SDK #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vowelparrot
force-pushed
the
vwp/invert
branch
2 times, most recently
from
fa1b086
to
01bcb77
Compare
vowelparrot
commented
Jun 5, 2023
| return f"{dataset_name}-{model_name}-{current_time}" | ||
|
|
||
|
|
||
| async def arun_on_dataset( |
There was a problem hiding this comment.
Not a 1-way door, but current PR just exposes these as functions rather than extending the Client. Choice is whether the syntactic sugar of client.run_on_dataset() instead of run_on_dataset(optional client) is more useful than it is confusing (confusing here in that the client has diff methods depending on how you import)
There was a problem hiding this comment.
I think either is fine tbh
agola11
approved these changes
Jun 6, 2023
| return f"{dataset_name}-{model_name}-{current_time}" | ||
|
|
||
|
|
||
| async def arun_on_dataset( |
There was a problem hiding this comment.
I think either is fine tbh
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
- Remove the client implementation (this breaks backwards compatibility for existing testers. I could keep the stub in that file if we want, but not many people are using it yet - Add SDK as dependency - Update the 'run_on_dataset' method to be a function that optionally accepts a client as an argument - Remove the langchain plus server implementation (you get it for free with the SDK now) We could make the SDK optional for now, but the plan is to use w/in the tracer so it would likely become a hard dependency at some point.
kacperlukawski
pushed a commit
to kacperlukawski/langchain
that referenced
this pull request
Jun 29, 2023
- Remove the client implementation (this breaks backwards compatibility for existing testers. I could keep the stub in that file if we want, but not many people are using it yet - Add SDK as dependency - Update the 'run_on_dataset' method to be a function that optionally accepts a client as an argument - Remove the langchain plus server implementation (you get it for free with the SDK now) We could make the SDK optional for now, but the plan is to use w/in the tracer so it would likely become a hard dependency at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could make the SDK optional for now, but the plan is to use w/in the tracer so it would likely become a hard dependency at some point.