New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Custom LLM Agent example #6429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nirga is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
hwchase17
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
hwchase17
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Jun 20, 2023
tconkling
added a commit
to tconkling/langchain
that referenced
this pull request
Jun 20, 2023
* master: (101 commits) add FunctionMessage support to `_convert_dict_to_message()` in OpenAI chat model (langchain-ai#6382) bump version to 206 (langchain-ai#6465) fix neo4j schema query (langchain-ai#6381) Update serpapi.py Support baidu list type answer_box (langchain-ai#6386) fix: llm caching for replicate (langchain-ai#6396) feat: use latest duckduckgo_search API to call (langchain-ai#6409) Harrison/unstructured page number (langchain-ai#6464) Improve error message (langchain-ai#6275) Fix the issue where ANTHROPIC_API_URL set in environment is not takin… (langchain-ai#6400) Fix broken links in autonomous agents docs (langchain-ai#6398) Update SinglStoreDB vectorstore (langchain-ai#6423) Fix for langchain-ai#6431 - chatprompt template with partial variables giing validation error (langchain-ai#6456) Harrison/functions in retrieval (langchain-ai#6463) Incorrect argument count handling (langchain-ai#5543) Fixed a link typo /-/route -> /-/routes. and change endpoint format (langchain-ai#6186) docs `retrievers` fixes (langchain-ai#6299) Update introduction.mdx (langchain-ai#6425) Fix Custom LLM Agent example (langchain-ai#6429) Remove backticks without clear purpose from docs (langchain-ai#6442) Update web_base.ipynb (langchain-ai#6430) ...
kacperlukawski
pushed a commit
to kacperlukawski/langchain
that referenced
this pull request
Jun 29, 2023
<!-- Thank you for contributing to LangChain! Your PR will appear in our release under the title you set. Please make sure it highlights your valuable contribution. Replace this with a description of the change, the issue it fixes (if applicable), and relevant context. List any dependencies required for this change. After you're done, someone will review your PR. They may suggest improvements. If no one reviews your PR within a few days, feel free to @-mention the same people again, as notifications can get lost. Finally, we'd love to show appreciation for your contribution - if you'd like us to shout you out on Twitter, please also include your handle! --> The `CustomOutputParser` needs to throw `OutputParserException` when it fails to parse the response from the agent, so that the executor can [catch it and retry](https://github.com/hwchase17/langchain/blob/be9371ca8f363bf1c748ac4af7fb4a0d75a365c5/langchain/agents/agent.py#L767) when `handle_parsing_errors=True`. <!-- Remove if not applicable --> #### Who can review? Tag maintainers/contributors who might be interested: @hwchase17 <!-- For a quicker response, figure out the right person to tag with @ @hwchase17 - project lead Tracing / Callbacks - @agola11 Async - @agola11 DataLoaders - @eyurtsev Models - @hwchase17 - @agola11 Agents / Tools / Toolkits - @hwchase17 VectorStores / Retrievers / Memory - @dev2049 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CustomOutputParser
needs to throwOutputParserException
when it fails to parse the response from the agent, so that the executor can catch it and retry whenhandle_parsing_errors=True
.Who can review?
Tag maintainers/contributors who might be interested: @hwchase17