Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: commented out editUrl option #6440

Merged
merged 2 commits into from
Jul 3, 2023
Merged

docs: commented out editUrl option #6440

merged 2 commits into from
Jul 3, 2023

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented Jun 19, 2023

docs: commented out the editUrl option

This removes the “Edit this page” link at the end of pages. See this link on this page, for example.

This link does not work.

New refactoring makes the docs structure the "hand-make" structure. The compiled pages do not map directly to the original page files. There should be a manually supported dictionary to map pages which is not here now.

@vercel
Copy link

vercel bot commented Jun 19, 2023

@leo-gan is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@leo-gan leo-gan marked this pull request as ready for review June 19, 2023 19:17
@leo-gan
Copy link
Collaborator Author

leo-gan commented Jun 22, 2023

@dev2049 A gentle reminder

@leo-gan
Copy link
Collaborator Author

leo-gan commented Jun 22, 2023

@bagatur Could you, please, review it? Thanks!

@leo-gan
Copy link
Collaborator Author

leo-gan commented Jun 24, 2023

@dev2049 Can you, please, review it? Thanks!

@@ -84,7 +84,7 @@ const config = {
({
docs: {
sidebarPath: require.resolve("./sidebars.js"),
editUrl: "https://github.com/hwchase17/langchain/edit/master/docs/",
// editUrl: "https://github.com/hwchase17/langchain/edit/master/docs/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we want to remove this again?

Copy link
Collaborator Author

@leo-gan leo-gan Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the “Edit this page” link at the end of pages. See this link on this page, for example.

This link does not work.

New refactoring makes the docs structure the "hand-make" structure. The compiled pages do not map directly to the original page files. There should be a manually supported dictionary to map pages which is not here now.

@leo-gan leo-gan requested a review from dev2049 June 27, 2023 03:21
@leo-gan
Copy link
Collaborator Author

leo-gan commented Jun 30, 2023

@rlancemartin Please review it. Thanks!

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 3, 2023 2:17am

@rlancemartin rlancemartin merged commit 16fbd52 into langchain-ai:master Jul 3, 2023
14 checks passed
@leo-gan leo-gan deleted the docs_edit_this_page_link branch July 3, 2023 16:03
bdonkey added a commit to bdonkey/langchain that referenced this pull request Jul 3, 2023
* master: (212 commits)
  Add SpacyEmbeddings class (langchain-ai#6967)
  docs: commented out `editUrl` option (langchain-ai#6440)
  Remove duplicate mongodb integration doc (langchain-ai#7006)
  Update get_started.mdx (langchain-ai#7005)
  openapi chain nit (langchain-ai#7012)
  Fix sample in FAISS section (langchain-ai#7050)
  Fix typo in google_places_api.py (langchain-ai#7055)
  move base prompt to schema (langchain-ai#6995)
  added `Brave Search` document_loader (langchain-ai#6989)
  Add JSON Lines support to JSONLoader (langchain-ai#6913)
  Vectara upd2 (langchain-ai#6506)
  docstrings `document_loaders` 2 (langchain-ai#6890)
  docstrings `document_loaders` 1 (langchain-ai#6847)
  Added filter and delete all option to delete function in Pinecone integration, updated base VectorStore's delete function (langchain-ai#6876)
  bump 221 (langchain-ai#7047)
  Rm retriever kwargs (langchain-ai#7013)
  Polish reference docs (langchain-ai#7045)
  Support params on GoogleSearchApiWrapper (langchain-ai#6810) (langchain-ai#7014)
  Fix typo (langchain-ai#7023)
  Fix openai multi functions agent docs (langchain-ai#7028)
  ...
vowelparrot pushed a commit that referenced this pull request Jul 4, 2023
aerrober pushed a commit to aerrober/langchain-fork that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants