-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated QA notebook #6801
Updated QA notebook #6801
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -79,7 +79,8 @@ | |||
"chunk_size = 500\n", | |||
"chunk_overlap = 0\n", | |||
"text_splitter = RecursiveCharacterTextSplitter(chunk_size=chunk_size, chunk_overlap=chunk_overlap)\n", | |||
"all_splits = text_splitter.split_documents(md_header_splits)" | |||
"all_splits = text_splitter.split_documents(md_header_splits)\n", | |||
"all_metadatas = [{\"source\": \"notion\"}, {\"source\": \"google-docs\"}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: we can actually remove all_metadatas
now b/c the splitter populates it for us.
Description: `all_metadatas` was not defined, `OpenAIEmbeddings` was not imported, Issue: #6723 the issue # it fixes (if applicable), Dependencies: lark, Tag maintainer: @vowelparrot , @dev2049 --------- Co-authored-by: rlm <pexpresss31@gmail.com>
Description: `all_metadatas` was not defined, `OpenAIEmbeddings` was not imported, Issue: langchain-ai#6723 the issue # it fixes (if applicable), Dependencies: lark, Tag maintainer: @vowelparrot , @dev2049 --------- Co-authored-by: rlm <pexpresss31@gmail.com>
Description:
all_metadatas
was not defined,OpenAIEmbeddings
was not imported,Issue: #6723 the issue # it fixes (if applicable),
Dependencies: lark,
Tag maintainer: @vowelparrot , @dev2049