WebBaseLoader: optionally raise exception in the case of http error #6823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrtj
commented
Jun 27, 2023
mrtj
commented
- Description: this PR adds the possibility to raise an exception in the case the http request did not return a 2xx status code. This is particularly useful in the situation when the url points to a non-existent web page, the server returns a http status of 404 NOT FOUND, but WebBaseLoader anyway parses and returns the http body of the error message.
- Dependencies: none,
- Tag maintainer: @rlancemartin, @eyurtsev,
- Twitter handle: jtolgyesi
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kacperlukawski
pushed a commit
to kacperlukawski/langchain
that referenced
this pull request
Jun 29, 2023
…angchain-ai#6823) - **Description**: this PR adds the possibility to raise an exception in the case the http request did not return a 2xx status code. This is particularly useful in the situation when the url points to a non-existent web page, the server returns a http status of 404 NOT FOUND, but WebBaseLoader anyway parses and returns the http body of the error message. - **Dependencies**: none, - **Tag maintainer**: @rlancemartin, @eyurtsev, - **Twitter handle**: jtolgyesi
vowelparrot
pushed a commit
that referenced
this pull request
Jul 4, 2023
…6823) - **Description**: this PR adds the possibility to raise an exception in the case the http request did not return a 2xx status code. This is particularly useful in the situation when the url points to a non-existent web page, the server returns a http status of 404 NOT FOUND, but WebBaseLoader anyway parses and returns the http body of the error message. - **Dependencies**: none, - **Tag maintainer**: @rlancemartin, @eyurtsev, - **Twitter handle**: jtolgyesi
aerrober
pushed a commit
to aerrober/langchain-fork
that referenced
this pull request
Jul 24, 2023
…angchain-ai#6823) - **Description**: this PR adds the possibility to raise an exception in the case the http request did not return a 2xx status code. This is particularly useful in the situation when the url points to a non-existent web page, the server returns a http status of 404 NOT FOUND, but WebBaseLoader anyway parses and returns the http body of the error message. - **Dependencies**: none, - **Tag maintainer**: @rlancemartin, @eyurtsev, - **Twitter handle**: jtolgyesi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.