-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Input Mapper in run_on_dataset #6894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
03 enhancement
Enhancement of existing functionality
needs work
PRs that need more work
labels
Jun 29, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
vowelparrot
force-pushed
the
vwp/eval_input_mapper
branch
from
June 29, 2023 01:15
059fa1b
to
7b22397
Compare
hinthornw
reviewed
Jun 29, 2023
@@ -651,6 +694,7 @@ def run_on_dataset( | |||
client: Optional[LangChainPlusClient] = None, | |||
tags: Optional[List[str]] = None, | |||
run_evaluators: Optional[Sequence[RunEvaluator]] = None, | |||
input_mapper: Optional[Callable[[Dict], Any]] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot of arguments. Also may as well make the other handlers an input mapper at that point?
vowelparrot
force-pushed
the
vwp/eval_input_mapper
branch
from
June 29, 2023 17:28
7b22397
to
06e09f9
Compare
vowelparrot
force-pushed
the
vwp/eval_input_mapper
branch
from
June 29, 2023 20:22
29272c3
to
23d39cd
Compare
vowelparrot
added a commit
that referenced
this pull request
Jul 4, 2023
If you create a dataset from runs and run the same chain or llm on it later, it usually works great. If you have an agent dataset and want to run a different agent on it, or have more complex schema, it's hard for us to automatically map these values every time. This PR lets you pass in an input_mapper function that converts the example inputs to whatever format your model expects
aerrober
pushed a commit
to aerrober/langchain-fork
that referenced
this pull request
Jul 24, 2023
If you create a dataset from runs and run the same chain or llm on it later, it usually works great. If you have an agent dataset and want to run a different agent on it, or have more complex schema, it's hard for us to automatically map these values every time. This PR lets you pass in an input_mapper function that converts the example inputs to whatever format your model expects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create a dataset from runs and run the same chain or llm on it later, it usually works great.
If you have an agent dataset and want to run a different agent on it, or have more complex schema, it's hard for us to automatically map these values every time. This PR lets you pass in an input_mapper function that converts the example inputs to whatever format your model expects