Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate RetrievalQA chain callbacks through its own LLMChain and StuffDocumentsChain #7853

Merged
merged 2 commits into from Aug 4, 2023

Conversation

alecf
Copy link
Contributor

@alecf alecf commented Jul 17, 2023

This is another case, similar to #5572 and #7565 where the callbacks are getting dropped during construction of the chains.

tagging @hwchase17 and @agola11 for callbacks propagation

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 24, 2023 9:09pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Jul 17, 2023
@alecf
Copy link
Contributor Author

alecf commented Jul 18, 2023

@agola11 friendly ping!

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is fine. @nfcampos @agola11 thoughts?

@hwchase17 hwchase17 merged commit 404d103 into langchain-ai:master Aug 4, 2023
23 checks passed
@alecf alecf deleted the alecf/qa-chain-callbacks branch August 8, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants