Issue 8081 Fix query results size bug. Other bug: pass vector_field param. #8085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: vector store
|
I just saw the folder/name change that happened right before this. I will fix the conflict and update the PR |
aerickson-clt
force-pushed
the
issue-8081-script-size-k
branch
from
fa7394e
to
63058b0
Compare
hwchase17
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@baskaryan
#8081
Likely the reason why the issue occurred is that OpenSearch's default k is 10, so it needs to be specified.
Here's a similar question about its cousin ElasticSearch
https://discuss.elastic.co/t/elasticsearch-returns-only-10-records-but-the-hit-is-507/136605
I tested this manually and also fixed the same issue in
_default_painless_scripting_query. In addition,_default_painless_scripting_querywas not passing thevector_fieldname to a sub call, so I fixed that too.I also tested this in the aws opensearch developer tools.