You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: the API response was changed
The previously used API no longer returns the "subtitle_url" property.
We should use another API to get subtitle_url property.
The subtitle_url returned by this API does not include the http schema and needs to be added.
dosubotbot
added
Ɑ: doc loader
Related to document loader module (not documentation)
🤖:bug
Related to a bug, vulnerability, unexpected error with an existing feature
labels
Jul 24, 2023
Please run lint (make format) to resolve test failures -
Success: no issues found in 1419 source files
poetry run black . --check
would reformat /home/runner/work/langchain/langchain/libs/langchain/langchain/document_loaders/bilibili.py
Oh no! 💥 💔 💥
1 file would be reformatted, [14](https://github.com/langchain-ai/langchain/actions/runs/5641762361/job/15302197107?pr=8165#step:7:15)21 files would be left unchanged.
Please run lint (make format) to resolve test failures -
Success: no issues found in 1419 source files
poetry run black . --check
would reformat /home/runner/work/langchain/langchain/libs/langchain/langchain/document_loaders/bilibili.py
Oh no! 💥 💔 💥
1 file would be reformatted, [14](https://github.com/langchain-ai/langchain/actions/runs/5641762361/job/15302197107?pr=8165#step:7:15)21 files would be left unchanged.
Sorry for that.I just ran 'make format' and the format has been fixed.
Could you please take another look.
I used the latest version of langchain. BiliBiliLoader uses cid to retrieve subtitles, but the subtitle is an empty list, making it impossible to obtain script information.
I used the latest version of langchain. BiliBiliLoader uses cid to retrieve subtitles, but the subtitle is an empty list, making it impossible to obtain script information.
🤖:bugRelated to a bug, vulnerability, unexpected error with an existing featureⱭ: doc loaderRelated to document loader module (not documentation)lgtmPR looks good. Use to confirm that a PR is ready for merging.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dosubot
bot
added
Ɑ: doc loader
hwchase17
added
the
lgtm
Description: fix the Loader 'BiliBiliLoader'
Issue: the API response was changed
The previously used API no longer returns the "subtitle_url" property.
We should use another API to get
subtitle_urlproperty.The
subtitle_urlreturned by this API does not include the http schema and needs to be added.Dependencies: Nope
Tag maintainer: @rlancemartin