Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(confluence): add markdown format option #8246

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

BastinFlorian
Copy link
Contributor

@BastinFlorian BastinFlorian commented Jul 25, 2023

Description:

Add the possibility to keep text as Markdown in the ConfluenceLoader
Add a bool variable that allows to keep the Markdown format of the Confluence pages.
It is useful because it allows to use MarkdownHeaderTextSplitter as a DataSplitter.
If this variable in set to True in the load() method, the pages are extracted using the markdownify library.

Issue:

4407

Dependencies:

Add the markdownify library

Tag maintainer:

@rlancemartin, @eyurtsev

Twitter handle:

FloBastinHeyI - https://twitter.com/FloBastinHeyI

@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 26, 2023 9:33pm
langchain-deprecated ⬜️ Ignored (Inspect) Jul 26, 2023 9:33pm

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Jul 25, 2023
@baskaryan baskaryan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 26, 2023
@baskaryan baskaryan merged commit a3ac9b2 into langchain-ai:master Jul 26, 2023
23 checks passed
hinthornw pushed a commit that referenced this pull request Jul 27, 2023
# Description:
**Add the possibility to keep text as Markdown in the ConfluenceLoader**
Add a bool variable that allows to keep the Markdown format of the
Confluence pages.
It is useful because it allows to use MarkdownHeaderTextSplitter as a
DataSplitter.
If this variable in set to True in the load() method, the pages are
extracted using the markdownify library.

  # Issue: 
[4407](#4407)
  # Dependencies: 
Add the markdownify library
  # Tag maintainer:
 @rlancemartin, @eyurtsev
  # Twitter handle:
 FloBastinHeyI - https://twitter.com/FloBastinHeyI

---------

Co-authored-by: Florian Bastin <florian.bastin@octo.com>
Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants