Harrison/sql query #8370
Merged
Harrison/sql query #8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…passed to all invoke/stream/batch calls when it is run
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:enhancement
baskaryan
reviewed
Jul 27, 2023
| ), | ||
| } | prompt_to_use | ||
| return ( | ||
| formatted_prompt | llm.bind(stop=["\nSQLResult:"]) | NoOpOutputParser() | _strip |
There was a problem hiding this comment.
think you can just str.strip instead of _strip
There was a problem hiding this comment.
ooc: do lambdas work here too?
hinthornw
reviewed
Jul 27, 2023
| "table_info": lambda x: db.get_table_info( | ||
| table_names=x.get("table_names_to_use") | ||
| ), | ||
| } | prompt_to_use |
There was a problem hiding this comment.
Oh this actually seems more confusing to me right now
baskaryan
reviewed
Jul 27, 2023
| prompt: Optional[BasePromptTemplate] = None, | ||
| k: int = 5, | ||
| ) -> RunnableSequence: | ||
| if prompt is not None: |
There was a problem hiding this comment.
if part of goal is to show how succinctly we can create this chain:
prompt = prompt or SQL_PROMPTS.get(db.dialect, PROMPT)There was a problem hiding this comment.
some weird typing thing prevented this
baskaryan
reviewed
Jul 27, 2023
| prompt_to_use = SQL_PROMPTS[db.dialect] | ||
| else: | ||
| prompt_to_use = PROMPT | ||
| formatted_prompt = { |
There was a problem hiding this comment.
input_to_prompt_vars = {...}
return input_to_prompt_vars | prompt_to_use | llm...more readable imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.