Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for prompts #8381

Merged
merged 12 commits into from
Aug 4, 2023
Merged

Update documentation for prompts #8381

merged 12 commits into from
Aug 4, 2023

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Jul 27, 2023

  • Documentation to favor creation without declaring input_variables
  • Cut out obvious examples, but add more description in a few places

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 9:07pm

@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Jul 27, 2023
@eyurtsev eyurtsev requested a review from baskaryan July 28, 2023 16:42
@eyurtsev eyurtsev changed the title update prompt docs WIP Update prompt documentation a bit Jul 28, 2023
@eyurtsev eyurtsev changed the title Update prompt documentation a bit Update documentation for prompts a bit Jul 28, 2023
@eyurtsev eyurtsev changed the title Update documentation for prompts a bit Update documentation for prompts Jul 28, 2023
@eyurtsev eyurtsev marked this pull request as ready for review July 28, 2023 17:02

<<<<<<< HEAD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some merge conflicts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@baskaryan
Copy link
Collaborator

few small comments, otherwise lgtm!

Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>
@baskaryan baskaryan merged commit 19dfe16 into master Aug 4, 2023
3 checks passed
@baskaryan baskaryan deleted the eugene/prompt_docs branch August 4, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants