Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bagatur/nuclia #8404

Merged
merged 33 commits into from
Aug 5, 2023
Merged

Bagatur/nuclia #8404

merged 33 commits into from
Aug 5, 2023

Conversation

baskaryan
Copy link
Collaborator

No description provided.

ebrehault and others added 24 commits July 20, 2023 09:55
@ebrehault
Nuclia tool to push file and collect results
e717807
@ebrehault
Nuclia document loader
660cddd
@ebrehault
unit tests
d9c7ceb
@ebrehault
linting
a576213
@ebrehault
store config at tool instantiation (+linting)
0294963
@ebrehault
fix typing for Python <3.10
e6deb36
@ebrehault
fix black on python 3.11
ee6adba
@ebrehault
add nucliadb-protos as optional dependency
c87e0d0
@ebrehault
add nucliadb-protos to test dependencies
7645cff
@ebrehault
refactor tool to push files or texts
bdbc9f9
@ebrehault
support async mode in Nuclia tool
050ea75
@ebrehault
Nuclia document transformer
524bc8f
@ebrehault
lint & clean
745a57c
@ebrehault
linting
dfdb23d
@ebrehault
fix poetry.lock
1582264
@baskaryan
Merge branch 'master' into nuclia-understanding-api
bb14905
@baskaryan
fmt
96f16c8
@ebrehault
linting
30e16fc
@ebrehault
rebase master
d3a903e
@ebrehault
Merge remote-tracking branch 'official/master' into nuclia-understand…
74503bc 
…ing-api
@ebrehault
Merge remote-tracking branch 'official/master' into nuclia-understand…
561cd35 
…ing-api
@baskaryan
Merge branch 'nuclia-understanding-api' of github.com:nuclia/langchai…
43587bf 
…n into nuclia-understanding-api
@baskaryan
merge
8c5fbfb
@baskaryan
fmt
d65f62d
@vercel
Copy link

vercel bot commented Jul 28, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2023 5:43pm

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Jul 28, 2023
@baskaryan baskaryan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 28, 2023
@baskaryan
Copy link
Collaborator Author

@ebrehault looks like nuclia working with protobuf>3.19 but seems that isn't enforced by the package requirements?

@ebrehault
Copy link
Contributor

@baskaryan right, we need protobuf 4.23, but where should I enforce that to not break other people integration based on protobuf 3?

@baskaryan
Copy link
Collaborator Author

@baskaryan right, we need protobuf 4.23, but where should I enforce that to not break other people integration based on protobuf 3?

we definitely shouldn't enforce in langchain, but nucliadb-protos probably should? so that when in CI it's installed it'd force protobuf to be updated. either way can just move the tests to integration tests for now

@baskaryan baskaryan merged commit 9fc9018 into master Aug 5, 2023
22 of 23 checks passed
@baskaryan baskaryan deleted the bagatur/nuclia branch August 5, 2023 17:44
@baskaryan baskaryan mentioned this pull request Aug 5, 2023
Closed
dev2049 pushed a commit that referenced this pull request Aug 6, 2023
@baskaryan
Revert "Bagatur/nuclia (#8404)"
3685bc4 
This reverts commit 9fc9018.
baskaryan added a commit that referenced this pull request Aug 6, 2023
@baskaryan
Revert "Bagatur/nuclia (#8404)" (#8832)
2f309a4
dev2049 pushed a commit that referenced this pull request Aug 6, 2023
@baskaryan
Revert "Revert "Bagatur/nuclia (#8404)" (#8832)"
1b2501c 
This reverts commit 2f309a4.
@ebrehault
Copy link
Contributor

Thank you @baskaryan (sorry for the late answer, I was on vacation).
I will fix the nucliadb-protos deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baskaryan @ebrehault