Add serialisable support for Replicate #8525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
馃:improvement
|
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
dqbd
commented
Jul 31, 2023
| @@ -46,6 +46,14 @@ class Config: | |||
|
|
|||
| extra = Extra.forbid | |||
|
|
|||
| @property | |||
| def lc_secrets(self) -> Dict[str, str]: | |||
| return {"replicate_api_token": "REPLICATE_API_TOKEN"} | |||
There was a problem hiding this comment.
Note: It seems like LangchainJS uses REPLICATE_API_KEY instead of REPLICATE_API_TOKEN. Haven't changed that as this would be a breaking change I assume?
There was a problem hiding this comment.
yea would be breaking. if we wanted could unify the secrets (to be TOKEN or API_KEY, no strong preference) and update the constructor (of whichever class we change) to accept both params/env vars, and just log a deprecation warning if they use the old one
There was a problem hiding this comment.
can also do that in a later PR
danielchalef
pushed a commit
to danielchalef/langchain
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.