Bagatur/runnable with fallbacks #8543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
dosubot
bot
added
the
馃:improvement
hwchase17
reviewed
Jul 31, 2023
eyurtsev
approved these changes
Aug 1, 2023
| class RunnableWithFallbacks(Serializable, Runnable[Input, Output]): | ||
| runnable: Runnable[Input, Output] | ||
| fallbacks: Sequence[Runnable[Input, Output]] | ||
| exceptions_to_handle: Tuple[Type[BaseException]] = (Exception,) |
There was a problem hiding this comment.
Should we make this into a required variable instead of allowing broad exceptions by default?
There was a problem hiding this comment.
don't feel super strongly but imagine at least some folks just want some LLM to work and want to fallback on any error
eyurtsev
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.