Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(issue #5163) Append reminder to nest multi-prompt router prompt output in JSON markdown code block, resolving JSON parsing error. #8709

Conversation

wnmurphy
Copy link
Contributor

@wnmurphy wnmurphy commented Aug 3, 2023

Resolves occasional JSON parsing error when some predictions are passed through a MultiPromptChain.

Makes this modification to multi_prompt_prompt.py, which is much cleaner than appending an entire example object, which is another community-reported solution.

@hwchase17, @baskaryan

cc: @SimasJan

…rompt output in JSON markdown code block, resolving JSON parsing error.
@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2023 6:01pm

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Aug 3, 2023
@eyurtsev
Copy link
Collaborator

eyurtsev commented Aug 4, 2023

@wnmurphy thanks, happy to merge this in.

I would expect only a minor improvement to parsing from this change to the prompt. I think to get a larger boost, one would need to add examples that are more concrete.

@eyurtsev eyurtsev merged commit b0d0399 into langchain-ai:master Aug 4, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants