-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BGE embeddings support #8848
Conversation
manmax31
commented
Aug 7, 2023
•
edited
Loading
edited
- Description: BGE-large embeddings from BAAI are at the top of MTEB leaderboard. Hence adding support for it.
- Tag maintainer: @baskaryan
- Twitter handle: @ManabChetia3
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any differences between this class and the normal huggingface class?
The only difference is it requires a prompt for retrieval like the Instructor models.
…________________________________
From: Harrison Chase ***@***.***>
Sent: Monday, August 7, 2023 2:56:19 PM
To: langchain-ai/langchain ***@***.***>
Cc: manmax31 ***@***.***>; Author ***@***.***>
Subject: Re: [langchain-ai/langchain] Add BGE embeddings support (PR #8848)
@hwchase17 commented on this pull request.
are there any differences between this class and the normal huggingface class?
—
Reply to this email directly, view it on GitHub<#8848 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAU7ATYXVMA5B26ZOQRRYXLXUBYPHANCNFSM6AAAAAA3GMU3L4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
ah, and we cant use the instructor embeddings cause different package and everything? |
Yes.
Good thing is Bge supports sentence transformers.
Would have been cleaner if instructor supported sentence transformers as well.
On the other hand, Bge also has their own https://github.com/FlagOpen/FlagEmbedding/tree/master
…________________________________
From: Harrison Chase ***@***.***>
Sent: Monday, August 7, 2023 3:21:35 PM
To: langchain-ai/langchain ***@***.***>
Cc: manmax31 ***@***.***>; Author ***@***.***>
Subject: Re: [langchain-ai/langchain] Add BGE embeddings support (PR #8848)
ah, and we cant use the instructor embeddings cause different package and everything?
—
Reply to this email directly, view it on GitHub<#8848 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAU7AT6XZATE7CRHX25XEADXUB3N7ANCNFSM6AAAAAA3GMU3L4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added an example nb, otherwise lgmt