ArgillaCallbackHandler to properly use default values for api_url and api_key
#9113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add semi-colon at the end of `push_to_argilla` since it returns the `FeedbackDataset` in Argilla since 1.14.0
Co-authored-by: Gabriel Martin <gabriel@argilla.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
|
thanks @alvarobartt! |
danielchalef
pushed a commit
to danielchalef/langchain
that referenced
this pull request
Aug 11, 2023
… and `api_key` (langchain-ai#9113) As of the recent PR at langchain-ai#9043, after some testing we've realised that the default values were not being used for `api_key` and `api_url`. Besides that, the default for `api_key` was set to `argilla.apikey`, but since the default values are intended for people using the Argilla Quickstart (easy to run and setup), the defaults should be instead `owner.apikey` if using Argilla 1.11.0 or higher, or `admin.apikey` if using a lower version of Argilla. Additionally, we've removed the f-string replacements from the docstrings. --------- Co-authored-by: Gabriel Martin <gabriel@argilla.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi to @agola11 or whoever is reading this! 🤗
What's in this PR?
As of the recent PR at #9043, after some testing we've realised that the default values were not being used for
api_keyandapi_url. Besides that, the default forapi_keywas set toargilla.apikey, but since the default values are intended for people using the Argilla Quickstart (easy to run and setup), the defaults should be insteadowner.apikeyif using Argilla 1.11.0 or higher, oradmin.apikeyif using a lower version of Argilla.Additionally, we've removed the f-string replacements from the docstrings.
P.S. Regarding the Twitter/X mention feel free to do so at either https://twitter.com/argilla_io or https://twitter.com/alvarobartt and https://twitter.com/gabrielmbmb_, or both if applicable, otherwise, just the first Twitter/X handle.