Fix for SVM retriever discarding document metadata #9141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
baskaryan
added
the
lgtm
|
thanks @MarkusSchiffer! |
|
Oh nice catch, I actually just thought of that edge case and you already made the change, phew! |
danielchalef
pushed a commit
to danielchalef/langchain
that referenced
this pull request
Aug 11, 2023
As stated in the title the SVM retriever discarded the metadata of passed in docs. This code fixes that. I also added one unit test that should test that. --------- Co-authored-by: Bagatur <baskaryan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the title the SVM retriever discarded the metadata of passed in docs. This code fixes that. I also added one unit test that should test that.
Ultimately it's a simple fix, but unfortunately poetry was not correctly installing dependencies in my environment so I was unable to run the unit test and linting (took way longer to try to set up environment than make my change). Would appreciate if someone with the environment set up could quickly try it out. I did test by directly modifying the langchain source code in my miniconda environment where I initially found the issue and it fixed the bug there, so it's not completely untested.