make openapi_schema_pydantic opt #9408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
eyurtsev
approved these changes
Aug 17, 2023
eyurtsev
reviewed
Aug 17, 2023
| def test_parse_api_operations( | ||
| spec_name: str, spec: OpenAPISpec, path: str, method: str | ||
| ) -> None: | ||
| @pytest.mark.requires("openapi_schema_pydantic") |
There was a problem hiding this comment.
i think we'll need to move it to integration tests with the requires marker right now
There was a problem hiding this comment.
ah shoot forgot to add to extended test, but why move to integration? are we gonna run extended test with pydantic v2 at some pt
zizhong
pushed a commit
to opaque-systems/langchain
that referenced
this pull request
Aug 18, 2023
Open
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.