Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with metadata in query #9500

Merged
merged 4 commits into from Aug 20, 2023
Merged

Conversation

ofermend
Copy link
Contributor

  • Description: Changed metadata retrieval so that it combines Vectara doc level and part level metadata
  • Tag maintainer: @rlancemartin
  • Twitter handle: @ofermend

@vercel
Copy link

vercel bot commented Aug 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2023 0:00am

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Aug 19, 2023
@ofermend
Copy link
Contributor Author

Tested that all unit tests pass and all demo examples (IPYNB in docs etc) also work with this change.

@baskaryan
Copy link
Collaborator

looks good to me! you'll want to run make format and make lint from libs/langchain to fix some linting issues

@ofermend
Copy link
Contributor Author

@baskaryan - yes, sorry I missed that. Now all fixed.

@hwchase17 hwchase17 merged commit a758496 into langchain-ai:master Aug 20, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants