fix call _get_keys for custom_evaluator #9763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the function _load_run_evaluators _get_keys is was not called in only custom_evaluator are used
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
dosubot
bot
added
the
🤖:bug
hinthornw
reviewed
Aug 25, 2023
| [isinstance(e, EvaluatorType) for e in config.evaluators] | ||
| if config.evaluators or config.custom_evaluators or any( | ||
| [isinstance(e, EvaluatorType) for e in config.evaluators] or any( | ||
| [isinstance(e, EvaluatorType) for e in config.custom_evaluators]) |
There was a problem hiding this comment.
Should only be StringRunEvaluatorChain for this second check
|
Hi, @hinthornw I finally set up the dev env properly. All tests passed. Let me know. |
|
Hi, @hinthornw @baskaryan Cloud you merge this PR? Or any other suggestions ? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function _load_run_evaluators the function _get_keys was not called if only custom_evaluators parameter is used