Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed GoogleCloudEnterpriseSearchRetriever returning an empty array #9858

Merged
merged 1 commit into from Aug 30, 2023

Conversation

lkuligin
Copy link
Collaborator

GoogleCloudEnterpriseSearchRetriever returned an empty array of documents earlier, fixed

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2023 1:40pm
langchain-deprecated ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2023 1:40pm

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Aug 28, 2023
@@ -150,7 +156,7 @@ def _convert_unstructured_search_response(
else "extractive_segments"
)

for chunk in getattr(derived_struct_data, chunk_type, []):
for chunk in derived_struct_data.get(chunk_type, []):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the type of derived_struct_data?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a dict

@baskaryan baskaryan merged commit d966ba6 into langchain-ai:master Aug 30, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants