Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use existing required args obj if specified #9883

Merged
merged 1 commit into from Aug 28, 2023
Merged

Use existing required args obj if specified #9883

merged 1 commit into from Aug 28, 2023

Conversation

hinthornw
Copy link
Collaborator

@hinthornw hinthornw commented Aug 28, 2023

We always overwrote the required args but we infer them by default. Doing it only the old way makes it so the llm guesses even if an arg is optional (e.g., for uuids)

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
langchain ⬜️ Ignored (Inspect) Aug 28, 2023 9:38pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Aug 28, 2023
@hinthornw hinthornw merged commit 3103f07 into master Aug 28, 2023
27 checks passed
@hinthornw hinthornw deleted the wfh/required branch August 28, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant