Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cube semantic loader: allow cubes processing #9927

Conversation

MikeNitsenko
Copy link
Contributor

@MikeNitsenko MikeNitsenko commented Aug 29, 2023

We've started to receive feedback (after launch) that using only views is confusing.
We're considering this as a good practice, as a view serves as a "facade" for your data - however, we decided to let users decide this on their own.

Solves the questions from:

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 29, 2023 1:32pm

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 29, 2023
@MikeNitsenko
Copy link
Contributor Author

@baskaryan

@baskaryan
Copy link
Collaborator

thanks @MikeNitsenko!

@baskaryan baskaryan merged commit c80e406 into langchain-ai:master Aug 29, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants