Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Updating the default value for `stripNewLines` to `false` in the `openai` embeddings. As removing newlines was beneficial for `V1` models (or `-001`), but should not be mandatory for `V2` models (or `-002`). This is explained in openai/openai-python#418 (comment) Therefor updating this field to be in line with the default set model `text-embedding-ada-002`. Also the langchain python library only enables this for `-001` models: https://github.com/langchain-ai/langchain/blob/c0f4b95aa9961724ab4569049b4c3bc12ebbacfc/libs/langchain/langchain/embeddings/openai.py#L466 * Reverting the default value, so it's `false` by default again. Marked with a comment to indicate this should be changed in a future minor release. Referenced the PR, as it contains the necessary information as to why this should be updated. * Resolving conflicts, adding changes again to new location.
- Loading branch information
1c486db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
langchainjs-api-refs β ./docs/api_refs
langchainjs-api-docs.vercel.app
langchainjs-api-refs-git-main-langchain.vercel.app
langchainjs-api-refs-langchain.vercel.app
api.js.langchain.com
1c486db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
langchainjs-docs β ./docs/core_docs/
langchainjs-docs-ruddy.vercel.app
langchainjs-docs-langchain.vercel.app
js.langchain.com
langchainjs-docs-git-main-langchain.vercel.app