refactor: use a single param for delete

libs/langchain-community/src/vectorstores/azure_cosmosdb.ts

@@ -41,6 +41,14 @@ export type AzureCosmosDBIndexOptions = {
   readonly similarity?: AzureCosmosDBSimilarityType;
 };
 
+/** Azure Cosmos DB Delete Parameters. */
+export type AzureCosmosDBDeleteParams = {
+  /** List of IDs for the documents to be removed. */
+  readonly ids?: string | string[];
+  /** MongoDB filter object or list of IDs for the documents to be removed. */
+  readonly filter?: Filter<MongoDBDocument>;
+};
+
 /**
  * Configuration options for the `AzureCosmosDBVectorStore` constructor.
  */
@@ -234,16 +242,13 @@ export class AzureCosmosDBVectorStore extends VectorStore {
   /**
    * Removes specified documents from the AzureCosmosDBVectorStore.
    * If no IDs or filter are specified, all documents will be removed.
-   * @param ids A list of IDs for the documents to be removed.
-   * @param filter A MongoDB filter object or list of IDs for the documents to be removed.
+   * @param params Parameters for the delete operation.
    * @returns A promise that resolves when the documents have been removed.
    */
-  async delete(
-    ids?: string | string[],
-    filter?: Filter<MongoDBDocument>
-  ): Promise<void> {
+  async delete(params: AzureCosmosDBDeleteParams = {}): Promise<void> {
     await this.initPromise;
 
+    const { ids, filter } = params;
     const idsArray = Array.isArray(ids) ? ids : [ids];
     const deleteIds = ids && idsArray.length > 0 ? idsArray : undefined;
     let deleteFilter = filter ?? {};

libs/langchain-community/src/vectorstores/tests/azure_cosmosdb.int.test.ts

@@ -185,7 +185,7 @@ describe.skip("AzureCosmosDBVectorStore", () => {
     ]);
 
     // Delete document matching specified ids
-    await vectorStore.delete(ids.slice(0, 1));
+    await vectorStore.delete({ ids: ids.slice(0, 1) });
 
     const results = await vectorStore.similaritySearch("politics", 10);
 
@@ -214,7 +214,7 @@ describe.skip("AzureCosmosDBVectorStore", () => {
     ]);
 
     // Delete document matching the filter
-    await vectorStore.delete(undefined, { a: 1 });
+    await vectorStore.delete({ filter: { a: 1 } });
 
     const results = await vectorStore.similaritySearch("politics", 10);