Adds structured tool chat agent and DynamicStructuredTool class #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on preventing StructuredTools being passed into existing agents
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… signatures for initialize
nfcampos
reviewed
May 3, 2023
langchain/src/agents/chat/index.ts
Outdated
| ` This agent requires descriptions for all tools.`; | ||
| throw new Error(msg); | ||
| } | ||
| // eslint-disable-next-line no-instanceof/no-instanceof | ||
| const complexTool = tools.find((tool) => !(tool instanceof Tool)); |
There was a problem hiding this comment.
instanceof checks can fail in some setups, is this actually needed?
There was a problem hiding this comment.
I've fixed the types now, so might not be needed anymore
nfcampos
reviewed
May 3, 2023
nfcampos
reviewed
May 12, 2023
| } | ||
|
|
||
| getFormatInstructions(): string { | ||
| return AGENT_ACTION_FORMAT_INSTRUCTIONS; |
There was a problem hiding this comment.
This is incorrect, it's returning an unformatted template string, without replacing the template vars. Either remove template vars, or format the template
nfcampos
reviewed
May 12, 2023
| } | ||
|
|
||
| getFormatInstructions(): string { | ||
| return FORMAT_INSTRUCTIONS; |
There was a problem hiding this comment.
This is missing a call to renderTemplate @jacoblee93
jacoblee93
changed the title
jacoblee93
changed the title
…micTool to DynamicStructuredTool
jacoblee93
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typing and prompt for #1095