Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: DRY-up the loadQAChain code so it's just using the same functions #1122

Merged
merged 2 commits into from
May 5, 2023

Conversation

justindra
Copy link
Contributor

The loadQAChain code was repeating the same code defined in other functions specified already for each type. Just DRY-ing it up to reduce any issues in the future when these functions are updated.

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 5, 2023 9:27am

@nfcampos nfcampos added the lgtm PRs that are ready to be merged as-is label May 5, 2023
@nfcampos
Copy link
Collaborator

nfcampos commented May 5, 2023

This is great, thanks!

@nfcampos nfcampos merged commit 085fcf4 into langchain-ai:main May 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants