Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ConversationalRetrievalQAChain] Fix wrong return type in Doc #1140

Merged
merged 2 commits into from
May 6, 2023

Conversation

killinsun
Copy link
Contributor

In ConversationalRetrievalQAChain doc, a return type in the example is still old.

@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 6, 2023 4:41am

@@ -13,6 +13,7 @@ The `ConversationalRetrievalQA` chain builds on `RetrievalQAChain` to provide a
It requires two inputs: a question and the chat history. It first combines the chat history and the question into a standalone question, then looks up relevant documents from the retriever, and then passes those documents and the question to a question answering chain to return a response.

To create one, you will need a retriever. In the below example, we will create one from a vectorstore, which can be created from embeddings.

import Example from "@examples/chains/conversational_qa.ts";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line appeared on the web page because of no blank line.

@nfcampos nfcampos added the lgtm PRs that are ready to be merged as-is label May 6, 2023
@nfcampos
Copy link
Collaborator

nfcampos commented May 6, 2023

Thanks!

@nfcampos nfcampos merged commit dcef8ea into langchain-ai:main May 6, 2023
@killinsun killinsun deleted the fix_wrong_return_type_in_doc branch May 7, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants