Separate base tracer from langchain tracers, Remove concept of session from base tracer, add missing exports, update console tracer accordingly #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nfcampos
commented
May 11, 2023
| }); | ||
| let tracerSession: TracerSession; | ||
| if (!response.ok) { | ||
| throw new Error( |
There was a problem hiding this comment.
I removed creating a fake session if it fails, as the fake session won't be accepted by the backend anyway, so there's no point
There was a problem hiding this comment.
Should we add a try / catch in manager.ts so the program doesn't crash when the env var is set?
There was a problem hiding this comment.
We already have that
nfcampos
commented
May 11, 2023
| serialized: run.serialized, | ||
| error: run.error, | ||
| inputs: run.inputs, | ||
| outputs: run.outputs ?? {}, |
There was a problem hiding this comment.
This is a little strange as runs with error shouldn't have outputs
There was a problem hiding this comment.
It's supposed to be optional - I can double check that it works, may have added unnecessarily
…n from base tracer, add missing exports, update console tracer accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.