Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chat Model Serialization #1226

Merged
merged 5 commits into from
May 12, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions langchain/src/callbacks/handlers/tracer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
RunInputs,
RunOutputs,
} from "../../schema/index.js";
import { mapChatMessagesToStoredMessages } from "../../stores/message/utils.js";
import { BaseCallbackHandler } from "../base.js";

export type RunType = "llm" | "chain" | "tool";
Expand Down Expand Up @@ -132,10 +133,7 @@ export abstract class BaseTracer extends BaseCallbackHandler {
): Promise<void> {
const execution_order = this._getExecutionOrder(parentRunId);
const convertedMessages = messages.map((batch) =>
batch.map((message) => ({
_type: message._getType(),
content: message.text, // TODO: Unify serialization btwn languages
}))
mapChatMessagesToStoredMessages(batch)
);
const run: Run = {
id: runId,
Expand Down
6 changes: 5 additions & 1 deletion langchain/src/callbacks/tests/tracer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,11 @@ test("Test Chat Message Run", async () => {
execution_order: 1,
child_execution_order: 1,
serialized: { name: "test" },
inputs: { messages: [[{ _type: "human", content: "Avast" }]] },
inputs: {
messages: [
[{ type: "human", data: { content: "Avast", role: undefined } }],
],
},
run_type: "llm",
outputs: { generations: [] },
child_runs: [],
Expand Down
15 changes: 9 additions & 6 deletions langchain/src/stores/message/dynamodb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,14 @@ export class DynamoDBChatMessageHistory extends BaseListChatMessageHistory {
const messages = items
.map((item) => ({
type: item.M?.type.S,
role: item.M?.role?.S,
text: item.M?.text.S,
data: {
role: item.M?.role?.S,
content: item.M?.text.S,
},
}))
.filter(
(x): x is StoredMessage => x.type !== undefined && x.text !== undefined
(x): x is StoredMessage =>
x.type !== undefined && x.data.content !== undefined
);
return mapStoredMessagesToChatMessages(messages);
}
Expand Down Expand Up @@ -133,12 +136,12 @@ export class DynamoDBChatMessageHistory extends BaseListChatMessageHistory {
S: message.type,
},
text: {
S: message.text,
S: message.data.content,
},
},
};
if (message.role) {
dynamoSerializedMessage.M.role = { S: message.role };
if (message.data.role) {
dynamoSerializedMessage.M.role = { S: message.data.role };
}
return dynamoSerializedMessage;
}),
Expand Down
9 changes: 6 additions & 3 deletions langchain/src/stores/message/redis.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,14 @@ export class RedisChatMessageHistory extends BaseListChatMessageHistory {
const previousMessages = orderedMessages
.map((item) => ({
type: item.type,
role: item.role,
text: item.text,
data: {
role: item.role,
content: item.text,
},
}))
.filter(
(x): x is StoredMessage => x.type !== undefined && x.text !== undefined
(x): x is StoredMessage =>
x.type !== undefined && x.data.content !== undefined
);
return mapStoredMessagesToChatMessages(previousMessages);
}
Expand Down
59 changes: 48 additions & 11 deletions langchain/src/stores/message/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,64 @@ import {
SystemChatMessage,
} from "../../schema/index.js";

// eslint-disable-next-line @typescript-eslint/no-explicit-any
export type AdditionalKwargs = Record<string, any>;
export interface StoredMessageData {
content: string;
role: string | undefined;
additional_kwargs?: AdditionalKwargs;
}

export interface StoredMessage {
type: string;
data: StoredMessageData;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do feel like I'd rather shim this, mark it, then remove the shim when 1.0.0 comes out as a breaking change - I know all this is recent but have seen a few people using it already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacoblee93 thoughts on the mapV1MessageToStoredMessage ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for it! Just would add a comment saying to remove when ready to make a breaking change so we don't forget about it

}

interface StoredMessageV1 {
type: string;
role: string | undefined;
text: string;
}

export function mapV1MessageToStoredMessage(
message: StoredMessage | StoredMessageV1
): StoredMessage {
if ("data" in message) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be some weird edge case where message has the data property set but is undefined - the more idiomatic way to do this in TS is (weirdly):

if (message.data !== undefined) {
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thank you!

return message as StoredMessage;
} else {
const v1Message = message as StoredMessageV1;
return {
type: v1Message.type,
data: {
content: v1Message.text,
role: v1Message.role,
},
};
}
}

export function mapStoredMessagesToChatMessages(
messages: StoredMessage[]
): BaseChatMessage[] {
return messages.map((message) => {
switch (message.type) {
const stored_msg = mapV1MessageToStoredMessage(message);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camel case to match JS variable name style

switch (stored_msg.type) {
case "human":
return new HumanChatMessage(message.text);
return new HumanChatMessage(stored_msg.data.content);
case "ai":
return new AIChatMessage(message.text);
return new AIChatMessage(stored_msg.data.content);
case "system":
return new SystemChatMessage(message.text);
default: {
if (message.role === undefined) {
throw new Error("Role must be defined for generic messages");
return new SystemChatMessage(stored_msg.data.content);
case "chat":
if (stored_msg.data?.additional_kwargs?.role === undefined) {
throw new Error("Role must be defined for chat messages");
}
return new ChatMessage(message.text, message.role);
}
return new ChatMessage(
stored_msg.data.content,
stored_msg.data.additional_kwargs.role
);
default:
throw new Error(`Got unexpected type: ${stored_msg.type}`);
}
});
}
Expand All @@ -38,7 +73,9 @@ export function mapChatMessagesToStoredMessages(
): StoredMessage[] {
return messages.map((message) => ({
type: message._getType(),
role: "role" in message ? (message.role as string) : undefined,
text: message.text,
data: {
content: message.text,
role: "role" in message ? (message.role as string) : undefined,
},
}));
}
32 changes: 32 additions & 0 deletions langchain/src/stores/tests/utils.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import { test, expect } from "@jest/globals";
import { mapV1MessageToStoredMessage } from "../message/utils.js";

test("mapV1MessageToStoredMessage", () => {
// Test that a V1 message is upgraded.
// Test that a v2 message is not changed.
const v1Message = {
type: "human",
role: "user",
text: "Hello, world!",
};
const v2Message = {
type: "human",
data: {
content: "Hello, world!",
role: "user",
},
};
expect(mapV1MessageToStoredMessage(v1Message)).toEqual(v2Message);

const v2Message2 = {
type: "human",
data: {
content: "Hello, world!",
role: "user",
additional_kwargs: {
foo: "bar",
},
},
};
expect(mapV1MessageToStoredMessage(v2Message2)).toEqual(v2Message2);
});