-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sagemaker endpoint support #1267
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This looks really cool! Could you add an integration test to demonstrate how to set up and use this? A comment with some details about how to set it up would be fine - we should expand it to a docs page later. |
@jacoblee93 have added the docs and integration test albeit skipped due to the need for a sagemaker endpoint that's accessible for ci to test. |
Thanks! Made a few modifications:
Also moved a few args and types around - worked great overall with HuggingFace GPT-2 for me. Thank you! |
@jacoblee93 thanks for making those changes. Is there anything else needed to get this over the line ? |
credentials_profile_name
arg, given the changes with the new aws-sdk v3 I am wondering if we should just allow passing in the full credential arg so people can use whatever aws credential provider they want.