Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creation of a SQL toolkit with a custom language model #1321

Merged
merged 1 commit into from
May 19, 2023

Conversation

jacoblee93
Copy link
Collaborator

Addresses and fixes #1202 by allowing the user to pass a preconfigured model into a SQL Toolkit.

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 18, 2023 8:58pm

super();
if (llmChain) {
this.llmChain = llmChain;
if (typeof llmChainOrOptions?._chainType === "function") {
Copy link
Collaborator Author

@jacoblee93 jacoblee93 May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @nfcampos saw this elsewhere to determine whether an object was a chain, but is this paradigm ok with you?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is fine

@jacoblee93 jacoblee93 requested a review from nfcampos May 18, 2023 21:03
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label May 18, 2023
@nfcampos nfcampos merged commit 3bdaf43 into langchain-ai:main May 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlToolkit does not allow for setting OpenAI API Key outside of environment variables.
2 participants