hnswlib: Throw error in index getter to dedupe code and have safer usage #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahriggan
force-pushed
the
feature/safer-index-usage
branch
2 times, most recently
from
1c6452e
to
698e840
Compare
micahriggan
changed the title
|
Great call! This cleans things up nicely. |
|
Another option would be to make the index property private, if you need access to it you can always create the instance with an index created outside? |
|
Yeah you could make it private, and you could use
|
nfcampos
force-pushed
the
feature/safer-index-usage
branch
from
698e840
to
6436cbc
Compare
|
Thanks so much for this @micahriggan , I've rebased this and pulling this in now |
nfcampos
pushed a commit
that referenced
this pull request
Feb 26, 2023
nfcampos
added a commit
that referenced
this pull request
Feb 27, 2023
* Use fetch adapter for openai axios * Update tsc build to output ESM only * Update all import paths to have extension per ESM requirements * Move all source files to src/ * Remove circular dependency * Fix jest config for ESM * Remove circular deps not possible with ESM * Throw error in index getter to dedupe code and have safer usage (#35) * Fix hnsw for esm * Fix usage of hnswlib with index passed in * Fix textsplitter for esm * Fix openai for esm * Fix hf for esm * Fix ESM for cohere * Fix ESM for serpapi * Fix esm in srt * Remove dependency on @vespaiach/axios-fetch-adapter which has an incorrect export * Fix examples for esm * Fix entrypoints * Fix test-exports for esm * Add fetch flag for node 16 ci job * Add a more thorough test for packaging * Fix docs build --------- Co-authored-by: micahriggan <micahriggan@users.noreply.github.com>
nfcampos
added a commit
that referenced
this pull request
Feb 27, 2023
* Add integration tests GH action (manual trigger for now), reduce cost of integration tests by using smallest possible models * Convert library to ESM codebase, ESM output (#124) * Use fetch adapter for openai axios * Update tsc build to output ESM only * Update all import paths to have extension per ESM requirements * Move all source files to src/ * Remove circular dependency * Fix jest config for ESM * Remove circular deps not possible with ESM * Throw error in index getter to dedupe code and have safer usage (#35) * Fix hnsw for esm * Fix usage of hnswlib with index passed in * Fix textsplitter for esm * Fix openai for esm * Fix hf for esm * Fix ESM for cohere * Fix ESM for serpapi * Fix esm in srt * Remove dependency on @vespaiach/axios-fetch-adapter which has an incorrect export * Fix examples for esm * Fix entrypoints * Fix test-exports for esm * Add fetch flag for node 16 ci job * Add a more thorough test for packaging * Fix docs build --------- Co-authored-by: micahriggan <micahriggan@users.noreply.github.com> --------- Co-authored-by: micahriggan <micahriggan@users.noreply.github.com>
nfcampos
added a commit
that referenced
this pull request
Feb 27, 2023
…rt library to ESM codebase, ESM output (#124), Add GH (manual) action for running integration tests (#119) * Use fetch adapter for openai axios * Remove node-fetch, add instructions for node 16 * Add GH (manual) action for running integration tests (#119) * Add integration tests GH action (manual trigger for now), reduce cost of integration tests by using smallest possible models * Convert library to ESM codebase, ESM output (#124) * Use fetch adapter for openai axios * Update tsc build to output ESM only * Update all import paths to have extension per ESM requirements * Move all source files to src/ * Remove circular dependency * Fix jest config for ESM * Remove circular deps not possible with ESM * Throw error in index getter to dedupe code and have safer usage (#35) * Fix hnsw for esm * Fix usage of hnswlib with index passed in * Fix textsplitter for esm * Fix openai for esm * Fix hf for esm * Fix ESM for cohere * Fix ESM for serpapi * Fix esm in srt * Remove dependency on @vespaiach/axios-fetch-adapter which has an incorrect export * Fix examples for esm * Fix entrypoints * Fix test-exports for esm * Add fetch flag for node 16 ci job * Add a more thorough test for packaging * Fix docs build --------- Co-authored-by: micahriggan <micahriggan@users.noreply.github.com> --------- Co-authored-by: micahriggan <micahriggan@users.noreply.github.com> * Fix one more import * Fix example * Also build docs in ci * Fix sql test in ci --------- Co-authored-by: micahriggan <micahriggan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to close, but seems like we can provide safer access to .index with a getter that throws if it hasn't been init'd
Also added a static method to init the HNSW Lib so we don't have to dupe the error handling each time
Oh yeah, thanks for making this, super cool