groq[major]: ChatGroq (groq integration package) #4467
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bracesproul
changed the title
bracesproul
changed the title
dosubot
bot
added
size:XL
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -0,0 +1,20 @@ | |||
| import { ChatGroq } from "@langchain/groq"; | |||
There was a problem hiding this comment.
Hey there! I've reviewed the code and noticed that the addition explicitly accesses an environment variable using process.env. I've flagged this for your review to ensure it aligns with our best practices. Let me know if you need further assistance!
| @@ -0,0 +1,52 @@ | |||
| import { ChatGroq } from "@langchain/groq"; | |||
There was a problem hiding this comment.
Hey team, just a heads up that I've flagged a change in the PR that accesses an environment variable using process.env. It's always good to review these changes to ensure proper handling of sensitive information. Keep up the great work!
| @@ -0,0 +1,94 @@ | |||
| { | |||
There was a problem hiding this comment.
Hey there! I noticed that this PR introduces changes to the project's dependencies, including both peer and dev dependencies. I've flagged this for your review as it's important to ensure the compatibility and stability of the project. Keep up the great work!
| @@ -0,0 +1,350 @@ | |||
| import { | |||
There was a problem hiding this comment.
Hey there! 👋 This is a friendly flag to highlight that the recent changes in the code are accessing environment variables via process.env and getEnvironmentVariable. This is an important change that should be reviewed by the maintainers. Great work on the code! 🚀
|
For the python integration I was asked to add a provider doc page. I assume there's something similar for JS. Here's an example from my PR: |
| const res = await chat.invoke([message]); | ||
| ``` | ||
|
|
||
| ## Development |
There was a problem hiding this comment.
Nice development section. I'm going to add this to the python readme.
| const messagesMapped = convertMessagesToGroqParams(messages); | ||
|
|
||
| if (params.stream) { | ||
| console.log("streaming via _generate"); |
|
LGTM! Remove that log and let's ship. |
At the moment, just the chat model page for JS! You're all good. |
| apiKey, | ||
| }); | ||
| this.temperature = fields?.temperature ?? this.temperature; | ||
| this.modelName = fields?.modelName ?? this.modelName; |
There was a problem hiding this comment.
can we pass the stream here?
this.stream = fields?.stream ?? this.stream;
There was a problem hiding this comment.
Hey, the recommended way of streaming is via the .stream method.
There was a problem hiding this comment.
are we deprecating the streaming property as well (for other chat models)?
There was a problem hiding this comment.
@bracesproul we should add this - there are niche but legit use cases for invoke with aggregating token information (a big one is agent streamLog actually).
There was a problem hiding this comment.
Will be in soon! https://github.com/langchain-ai/langchainjs/pull/4573/files
There was a problem hiding this comment.
appreciate the quick action as always!
No description provided.