community[patch]: fix astra initialize error

[nicoloboschi]

Currently in the AstraDBVectorStore#initialize method if there is an error while creating the collection, the error is suppressed, assuming the collection already exists. This is wrong because:

• if the collection already exists with the same options, the Astra Data API won't return errors
• In case of auth, network or server errors, the user can't really see the errors and no error is raised

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-api-refs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 24, 2024 4:28pm
langchainjs-docs	✅ Ready (Inspect)	Visit Preview		Feb 24, 2024 4:28pm

[jacoblee93]

Thank you!

[Gr33nLight]

Hello regarding this, I noticed a pretty big impact of the call this.astraDBClient.createCollection in the initialize in terms of response time. Even if the collection already exists, this call takes multiple seconds to complete (2.2 to 2.5s im my testing). This is not ideal if the collection is already present, may a suggest in a pull request the option to disable automatic collection creation?

@nicoloboschi @jacoblee93

[nicoloboschi]

@Gr33nLight I don't think it's related to the pull itself. the API calls are the same.
Checking if the collection already exists would take the same time.
Skipping the collection creation is very risky from a usability point of view 🤔

[Gr33nLight]

Yes I agree in regards to the usability, It is more of a specific case, in our product speed is a priority and having 2s added to every request is not the best. We are using a modified version so its not that big of a issue for us, but I wanted to point this out anyways as I was not experiencing this slow down with the other adapters.
Maybe I'll check with the guys at Datastax to see if something can be done at client level, to maybe speed up some calls.