-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community[patch]: Allow must_not filter in Elasticsearch VectorStore #4664
Merged
jacoblee93
merged 2 commits into
langchain-ai:main
from
Sequesto:elasticsearch-vector-store-allow-must-not-filter
Mar 12, 2024
Merged
community[patch]: Allow must_not filter in Elasticsearch VectorStore #4664
jacoblee93
merged 2 commits into
langchain-ai:main
from
Sequesto:elasticsearch-vector-store-allow-must-not-filter
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jacoblee93
reviewed
Mar 9, 2024
Hey @LaurensTsestigh, I can't fix lint - can you update? |
I think this should be fine now! |
joemcelroy
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:improvement
Medium size change to existing code to handle new use-cases
lgtm
PRs that are ready to be merged as-is
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our project we needed to exclude some ids of certain entities when searching the VectorStore.
As the current implementation doesn't support the must_not filter yet, I've added it as an "exclude" operator to be flexible and populate the must_not filter accordingly.