azure-openai[patch]: feat: add azureOpenAIApiDeploymentName for AzureChatOpenAI constructor #4668
Conversation
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -256,7 +256,8 @@ export class AzureChatOpenAI | |||
| getEnvironmentVariable("AZURE_OPENAI_API_ENDPOINT"); | |||
There was a problem hiding this comment.
Hey team, I've flagged this PR for your review as it includes changes that explicitly access environment variables using the getEnvironmentVariable function. Please take a look and ensure everything is in order.
| @@ -256,7 +256,8 @@ export class AzureChatOpenAI | |||
| getEnvironmentVariable("AZURE_OPENAI_API_ENDPOINT"); | |||
|
|
|||
| this.azureOpenAIApiCompletionsDeploymentName = | |||
| fields?.azureOpenAIEmbeddingsApiDeploymentName ?? | |||
| (fields?.azureOpenAIEmbeddingsApiDeploymentName || | |||
There was a problem hiding this comment.
Should this even take into account azureOpenAIEmbeddingsApiDeploymentName? I guess we have to leave it there for backwards compatibility...
There was a problem hiding this comment.
While backward compatibility is important, I'm thinking it might be okay to remove azureOpenAIEmbeddingsApiDeploymentName in chat_models since it seems to confuse users.
What do you think?
There was a problem hiding this comment.
I created a PR for deprecating azureOpenAIEmbeddingsApiDeploymentName .
#4714
jacoblee93
changed the title
|
Thank you! Sorry for the delay. |
SpringMT
deleted the
feature/add-azureOpenAIApiDeploymentName-for-chat_models
branch
Fixes # (issue)
AzureOpenAIEmbeddings and AzureOpenAI can use
azureOpenAIApiDeploymentNamein constructer however AzureChatOpenAI not.So, add
azureOpenAIApiDeploymentNameto AzureChatOpenAI.