-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs[minor]: Swap gtag for supabase #4710
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -304,6 +304,12 @@ const config = { | |||
async: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey team, just wanted to flag this change for review as it explicitly accesses environment variables using process.env
. It's always good to double-check any changes related to environment variables. Great work overall!
@@ -23,13 +23,16 @@ | |||
"format:check": "prettier --check \"**/*.{js,jsx,ts,tsx,md,mdx}\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! 👋 I noticed the addition of the "@supabase/supabase-js" dependency in the package.json file, which seems to be a hard dependency change. I've flagged this for the maintainers to review. Great work on the PR! 🚀
@@ -90,27 +90,69 @@ function SvgThumbsDown() { | |||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I've reviewed the code and noticed that the recent changes directly access environment variables via process.env
. I've flagged this for your review to ensure the proper handling of environment variables. Let me know if you need further assistance with this.
* docs[minor]: Swap gtag for supabase * cr * env var support * Add generated types * cr * add to build script * update gen location * cr * drop gen from build * uncomment non prod check * drop supabase dep * add back supabase dev dep * drop docusaurus2-dotenv
Added deps:
@supabase/supabase-js
- for sending insertssupabase
- dev dep, for generating types via clidotenv
for loading env varsAdded script:
yarn gen
- will auto generate the database schema types using the supabase CLI. Not necessary for development, but is useful. Requires authing with the supabase CLI (will error out w/ instructions if you're not authed).Added functionality:
https://api.ipify.org
so we can filter out abuse down the line)TODO: