Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs[minor]: Swap gtag for supabase #4710

Merged
merged 13 commits into from
Mar 11, 2024
Merged

Conversation

bracesproul
Copy link
Collaborator

@bracesproul bracesproul commented Mar 11, 2024

Added deps:

  • @supabase/supabase-js - for sending inserts
  • supabase - dev dep, for generating types via cli
  • dotenv for loading env vars

Added script:

  • yarn gen - will auto generate the database schema types using the supabase CLI. Not necessary for development, but is useful. Requires authing with the supabase CLI (will error out w/ instructions if you're not authed).

Added functionality:

  • pulls users IP address (using a free endpoint: https://api.ipify.org so we can filter out abuse down the line)

TODO:

  • add env vars to vercel

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 9:00pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 11, 2024 9:00pm

@bracesproul bracesproul marked this pull request as ready for review March 11, 2024 21:22
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Mar 11, 2024
@bracesproul bracesproul merged commit eab68fb into main Mar 11, 2024
14 checks passed
@bracesproul bracesproul deleted the brace/swap-gtag-supabase branch March 11, 2024 21:23
@@ -304,6 +304,12 @@ const config = {
async: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just wanted to flag this change for review as it explicitly accesses environment variables using process.env. It's always good to double-check any changes related to environment variables. Great work overall!

@@ -23,13 +23,16 @@
"format:check": "prettier --check \"**/*.{js,jsx,ts,tsx,md,mdx}\"",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I noticed the addition of the "@supabase/supabase-js" dependency in the package.json file, which seems to be a hard dependency change. I've flagged this for the maintainers to review. Great work on the PR! 🚀

@@ -90,27 +90,69 @@ function SvgThumbsDown() {
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code and noticed that the recent changes directly access environment variables via process.env. I've flagged this for your review to ensure the proper handling of environment variables. Let me know if you need further assistance with this.

Janaka-Steph pushed a commit to Janaka-Steph/langchainjs that referenced this pull request Mar 15, 2024
* docs[minor]: Swap gtag for supabase

* cr

* env var support

* Add generated types

* cr

* add to build script

* update gen location

* cr

* drop gen from build

* uncomment non prod check

* drop supabase dep

* add back supabase dev dep

* drop docusaurus2-dotenv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant